Re: [evolution-patches] Fix for Evolution 1.2 shortcut migration

[Frederic Crozat <fcrozat mandrakesoft com>]

Le mer 10/09/2003 à 06:07, Ettore Perazzoli a écrit :
> Hello Frederic,
> 
> On Tue, 2003-09-09 at 14:40, Frederic Crozat wrote:
> > The attach patch fixes shortcuts migration from Evolution 1.2 :
> > http://qa.mandrakesoft.com/show_bug.cgi?id=4927
> > 
> > Strangely, you need to feed libxml2 with locale-encoded strings (and not
> > UTF-8 ones) for shortcuts.xml migration from 1.2 (otherwise you'll end
> > with very ugly strings, which is quite obvious in french).
> 
> Hmm, I don't understand why this patch works at all...  The current
> shortcut code always sets the data in the libxml tree as UTF-8.  So why
> would getting old UTF-8 data and converting it to locale generate a
> valid tree?  (It's also the opposite of what the rest of the XML fixing
> code in that file does...)

I don't understand either :)) Maybe libxml2 switched to locale encoding
when reading shortcuts.xml and then expected all strings to be in locale
encoding.. 

> Do you happen to have an example shortcuts.xml file before and after the
> conversion?  Maybe this would help us understand what is going on...

Yep, I've attached 1.2, 1.4 broken and 1.4 correct files..

BTW, when migrating, I also get :
warning: failed to load external entity
"/home/a/evolution/config/storage-set-expanded:default"

(evolution:25542): evolution-shell-CRITICAL **: fome e-storage-set.c:
line 639 (e_storage_set_get_folder): assertion 'g_path_is_absolute
(path)' failed
(evolution:25542): evolution-shell-CRITICAL **: fome e-storage-set.c:
line 639 (e_storage_set_get_folder): assertion 'g_path_is_absolute
(path)' failed

and evolution refuses to exit properly.. You have to kill it and wombat
to get a working evo :(

-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft

<?xml version="1.0"?>
<shortcuts>
  <group title="Raccourcis" icon_size="large">
    <item name="R&#195;&#169;sum&#195;&#169;" type="summary">evolution:/summary</item>
    <item name="Bo&#195;&#174;te de r&#195;&#169;ception" type="mail" icon="inbox">default:mail</item>
    <item name="Calendrier" type="calendar">default:calendar</item>
    <item name="T&#195;&#162;ches" type="tasks">default:tasks</item>
    <item name="Contacts" type="contacts">default:contacts</item>
  </group>
</shortcuts>

<?xml version="1.0"?>
<shortcuts><group title="Raccourcis" icon_size="large"><item name="R&#xC3;&#xA9;sum&#xC3;&#xA9;" type="summary">evolution:/summary</item><item name="Bo&#xC3;&#xAE;te de r&#xC3;&#xA9;ception" type="mail" icon="inbox">default:mail</item><item name="Calendrier" type="calendar">default:calendar</item><item name="T&#xC3;&#xA2;ches" type="tasks">default:tasks</item><item name="Contacts" type="contacts">default:contacts</item></group></shortcuts>

<?xml version="1.0"?>
<shortcuts><group title="Raccourcis" icon_size="large"><item name="R&#xE9;sum&#xE9;" type="summary">evolution:/summary</item><item name="Bo&#xEE;te de r&#xE9;ception" type="mail" icon="inbox">default:mail</item><item name="Calendrier" type="calendar">default:calendar</item><item name="T&#xE2;ches" type="tasks">default:tasks</item><item name="Contacts" type="contacts">default:contacts</item></group></shortcuts>