Re: [evolution-patches] bug 47872,mail,:missing access key in the action menu

[Yuedong Du <yuedong du sun com>]

Thanks for such detailed comments!
Modified as Anna suggestted and commited into trunk.


On Mon, 2003-09-08 at 18:00 -0400, Anna Marie Dirks wrote:
> Hello, Yuedong. 
> 
> Thanks for another nice patch! I appreciate your contributions very
> much. 
> 
> It must have been difficult to find a way to change the accelerators to
> add these new menuitems -- the accelerators in the mailer are like a
> house built from playing cards; if you change the wrong one, everything
> will fall apart. :)
> 
> In order to make this patch fully compliant with the HIG, the
> accelerator for "Post a Reply" should be "y", not "e". I just wrote a
> similar message to Tim Wo about how to choose access keys, and you might
> have seen the link that I sent him. Just in case you didn't see it, here
> it is:
> http://developer.gnome.org/projects/gup/hig/1.0/userinput.html#choosing-access-keys  . 
> 
> The interesting thing (to me) is that according to the HIG, the
> accelerator for "Expunge" really should be "x" -- just the way your
> patch has it. (Because the sound of the letter "x" is much more like the
> first sound of the word "Expunge" than the sound of the letter "e" is.)
> 
> So -- if you change change the accelerator for "Reply" to "y", then this
> patch will be all set to be commited. (To HEAD, that is, not to the
> branch, since this changes some strings.) 
> 
> Thanks again! Let me know if this makes sense to you, and if you need
> any more clarification. 
> 
> regards,
> Anna 
> 
> On Sun, 2003-09-07 at 22:29, Yuedong Du wrote:
> 
> > This patch add mnemomics to 'Post New Message' and 'Post a Reply'.
> > Because I can not find one in 'Post a Reply' that do not confict with
> > other entries, I also change the mnemonics of 'Expunge' to 'x'. So that
> > 'Post a Reply' just use 'e'.
> > 
> > 
> > Thanks
> > York