[evolution-patches] soup leak fix and namespace fix



The leak fix probably affects rcd. It's something I noticed on head. The
other thing is just part of my quest to get Evolution building happily
on OS X. (Soup stole its md5 functions from evolution, so they have the
same names currently, which is bad.)


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/libsoup/ChangeLog,v
retrieving revision 1.318
diff -u -r1.318 ChangeLog
--- ChangeLog	11 Aug 2003 13:50:49 -0000	1.318
+++ ChangeLog	3 Sep 2003 17:30:43 -0000
@@ -1,3 +1,11 @@
+2003-09-03  Dan Winship  <danw ximian com>
+
+	* libsoup/soup-server.c (read_done_cb, write_done_cb): Unref the
+	reader/writer rather than leaking them.
+
+	* libsoup/md5-utils.h: Add some #defines here to avoid namespace
+	pollution
+
 2003-08-07  Dan Winship  <danw ximian com>
 
 	* libsoup/soup-auth.c (soup_auth_lookup, soup_auth_set_context,
Index: libsoup/md5-utils.h
===================================================================
RCS file: /cvs/gnome/libsoup/libsoup/md5-utils.h,v
retrieving revision 1.1
diff -u -r1.1 md5-utils.h
--- libsoup/md5-utils.h	23 Apr 2001 07:57:41 -0000	1.1
+++ libsoup/md5-utils.h	3 Sep 2003 17:30:43 -0000
@@ -28,6 +28,13 @@
 
 #include <glib.h>
 
+#define MD5Context               SoupMD5Context
+#define md5_get_digest           soup_md5_get_digest
+#define md5_get_digest_from_file soup_md5_get_digest_from_file
+#define md5_init                 soup_md5_init
+#define md5_update               soup_md5_update
+#define md5_final                soup_md5_final
+
 typedef struct {
 	guint32 buf[4];
 	guint32 bits[2];
Index: libsoup/soup-server.c
===================================================================
RCS file: /cvs/gnome/libsoup/libsoup/soup-server.c,v
retrieving revision 1.35
diff -u -r1.35 soup-server.c
--- libsoup/soup-server.c	17 Jun 2003 12:24:12 -0000	1.35
+++ libsoup/soup-server.c	3 Sep 2003 17:30:43 -0000
@@ -315,6 +315,7 @@
 {
 	SoupMessage *msg = user_data;
 
+	soup_transfer_write_unref (msg->priv->write_tag);
 	msg->priv->write_tag = 0;
 	destroy_message (msg);
 }
@@ -862,6 +863,7 @@
 	SoupSocket *server_sock = req->priv->server_sock;
 	GIOChannel *channel;
 
+	soup_transfer_read_unref (req->priv->read_tag);
 	req->priv->read_tag = 0;
 
 	call_handler (req, data, soup_context_get_uri (req->context)->path);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]