Re: [evolution-patches] Re: new patch for review (#45776)

[JP Rosevear <jpr ximian com>]

Did you have any follow up for this Wu?

-JP

On Mon, 2003-09-22 at 06:53, Rodrigo Moya wrote:
> On Fri, 2003-09-12 at 10:43, wu yang wrote:
> > Hi
> > This is a new patch for evolution calendar keyboard navigation .
> > Bug #(45776)
> > In DayView and WeekView, Alt + Arrow Keys with the event is selected, 
> > Move a selected event through time lines
> > p45776_withChanglog is for evolution calendar.
> > etext_patch is for e-text in gal.
> > Thanks
> > 
> > ______________________________________________________________________
> > @@ -4418,11 +4426,17 @@
> >  	for (event_num = 0; event_num < day_view->events[day]->len;
> >  	     event_num++) {
> >  		e_day_view_reshape_day_event (day_view, day, event_num);
> > -		if (event_num == day_view->resize_event_num) {
> > +
> >  			EDayViewEvent *event;
> > -			event = &g_array_index (day_view->events[day], EDayViewEvent,
> > -				event_num);
> > +		gchar *current_comp_string;
> > +
> this is wrong, it declares a variable after the call to
> e_day_view_reshape_day_event, which is not ANSI C. Or am I wrong?
> 
> > +		if (strncmp(current_comp_string, day_view->last_edited_comp_string,50) == 0) {			
> >
> please use evo coding style, which is to add a space before the (, so:
> 	if (strncmp (...
> 
> there are a few places like this in the patch, so please fix them.
> 
> > @@ -2395,6 +2403,18 @@
> >  		for (span_num = 0; span_num < event->num_spans; span_num++) {
> >  			e_week_view_reshape_event_span (week_view, event_num,
> >  							span_num);
> > +
> > +			gchar *current_comp_string;
> >
> the same here. Declarations come always at the beginning of code blocks.
> 
> > @@ -3226,22 +3407,26 @@
> >  #endif
> >  
> >  	/*Navigation through days with arrow keys*/
> > +	if (!((event->state & GDK_SHIFT_MASK)
> > +	      ||(event->state & GDK_CONTROL_MASK)
> > +	      ||(event->state & GDK_MOD1_MASK))) {
> >  	switch (event->keyval) {
> >  	case GDK_Up:
> >
> is the patch wrong or shouldn't these lines (switch) be tabbed, since
> they are under the (if !...)?
> 
> cheers
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.