Re: [evolution-patches] patch for 24026 try harder to not send




>that is just plain wrong and likely to cause data corruption. Do you
>understand why the code returns UTF-8 there? 
>

This may not be terribly wrong as you think, see that here the user defined 
encoding will be selected only if other detection mechanism do fail, so 

No, it is terribly wrong as we think :)  Because it isn't just used for user set character sets.  And sending mail with an invalid charset is broken - somewhat like outlook.

I agree with Dan, we should either make it session specific, and make filters or whatever needs it _depend on the session_.

Or a much easier way, and just as valid for most cases, would just to be to have a global accessor to get/set a _list_ of preferred charsets.  That way we can also abstract away the local dependent stuff behind the same interface.

I also might add using utf8 is (or at least, should be) becoming less of a problem with more modern clients.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]