Re: [evolution-patches] Patch for 48869(Cannot drap&drop appointment from one window to another), Calendar related

[Rodrigo Moya <rodrigo ximian com>]

On Mon, 2003-10-13 at 10:05, Harry Lu wrote:
> Rodrigo,
>     Attached is the patch for HEAD. I modified it a little according
> to the changes of selection_received() in e-cal-view.c of HEAD.
>
looks ok, although it looks like the code to actually add the events to
the calendar could be shared, since it is repeated in a couple of
places, apart from already being in selection_received. Could you please
try to move that code to a separate function and call it from the other
places?

Also, I wonder if all this work should be done in the new-ui-branch,
which will be merged to HEAD soon. Thus, the merging would be easier,
since there are a lot of changes in that branch, and if we continue
making changes like this one to HEAD, I'm sure the merge will be more
difficult :-) Ettore, what do you think?

The thing that worries me is that you are writing new code that will
need to be changed when merging with the new-ui-branch, since many
things have changed.

>     As I tested, with my patch, drag and drop bewteen different window
> works fine. However, I found a bug in the existing code before
> applying my patch. When I try to drag a event from main canvas to top
> canvas in the same window, evolution will hang there. gdb shows it
> hangs at malloc() in icalmemory_new_buffer() in icalmemory.c. Sorry I
> cannot figure out why. Dragging from top canvas to top canvas in the
> same window works fine. 
>
hmm, could you provide the backtrace?

cheers