[evolution-patches] Re: patch for bug 49599



On Mon, 2003-10-13 at 05:11, leon.zhang wrote:
> 1) Implement support Del key event process in gal module, and send
> "key_press" signal to ETableItem and ETree.

I don't think you need to do that?..  You should get the key press
signal without having to special case the Delete case.

> 2) In shell module of evolution, implement support to signals related
> to "Del key" event in ETree and EStorageSetView.

I am not sure this is a good idea.  I think the Delete key should be
mapped to "delete current mail/calendar/addressbook item", but not
"delete current folder", which is a considerably more destructive action
and could be easily triggered by mistake (it's not always easy for the
user to tell where the keyboard focus is).

Users can still delete folders with the keyboard using the File menu,
which is already keyboard accessible through virtue of being a menu.

(And in any case, the right way to do this is through the BonoboUI menus
and menu shortcuts, not by binding keypresses directly.  Binding a menu
action to a key press event is almost always the wrong thing to do.)

-- Ettore



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]