[evolution-patches] Gtkhtml : fix incorrect generated html (bug 38589)



Hi all,

I've found why some people had problem when typing a line of '-', saving
email as Draft and seeing dashes line truncated to '--'. Gtkhtml wasn't
adding comment closing tag when writing object data tags. See Bugs
http://bugzilla.ximian.com/show_bug.cgi?id=38589 and
http://qa.mandrakesoft.com/show_bug.cgi?id=3947

The attached patch fixes the problem (for 1.4 branch, I haven't looked
at HEAD yet).

Permission to commit ?
-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft
Index: src/ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.1814.2.13
diff -u -r1.1814.2.13 ChangeLog
--- src/ChangeLog	24 Sep 2003 17:10:02 -0000	1.1814.2.13
+++ src/ChangeLog	10 Oct 2003 15:11:10 -0000
@@ -1,3 +1,8 @@
+2003-10-10  Frederic Crozat  <fcrozat mandrakesoft com>
+
+	* htmlobject.c: (object_save_data):
+	Close comment when saving object data (bug #38589).
+
 2003-07-31  Radek Doulik  <rodo ximian com>
 
 	* htmlengine-edit.c (html_engine_select_spell_word_editable): fix
Index: src/htmlobject.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlobject.c,v
retrieving revision 1.160.6.2
diff -u -r1.160.6.2 htmlobject.c
--- src/htmlobject.c	6 Aug 2003 06:25:43 -0000	1.160.6.2
+++ src/htmlobject.c	10 Oct 2003 15:11:10 -0000
@@ -1648,7 +1648,7 @@
 	/* printf ("object %s %s\n", g_quark_to_string (key_id), str); */
 	if (!str) {
 		/* printf ("save %s %s -> %s\n", state->save_data_class_name, g_quark_to_string (key_id), (gchar *) data); */
-		html_engine_save_output_string (state, "<!--+GtkHTML:<DATA class=\"%s\" key=\"%s\" value=\"%s\">",
+		html_engine_save_output_string (state, "<!--+GtkHTML:<DATA class=\"%s\" key=\"%s\" value=\"%s\">-->",
 						state->save_data_class_name, g_quark_to_string (key_id), data);
 		html_engine_set_class_data (state->engine, state->save_data_class_name, g_quark_to_string (key_id), data);
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]