[evolution-patches] Fix for bug #48753:Pasting text from Evolution (email message) to Emacs obliterates the newlines]



Hello Larry,

I have created a new patch for this bug. After source code research, I found Rodo's patch for the get_length() function in htmlobject.c cause the regression, that cause clueflow's length aways be zero and cannot be selected. In my new patch, I add a new function named "get_length"in clueflow, This function will return the real length of clueflow. I hope you can review this patch. If you won't agree my fix, Can you give me some advice to help me fix this bug.

Thanks
Anto
Larry Ewing wrote:

This patch will end up adding padding in places it shouldn't.  I'd much
rather see some explaination of when and where the old logic was broken.

--Larry

On Thu, 2003-09-25 at 22:15, Antonio Xu wrote:

Index: src/htmlclueflow.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlclueflow.c,v
retrieving revision 1.288
diff -u -p -r1.288 htmlclueflow.c
--- src/htmlclueflow.c	20 May 2003 18:25:14 -0000	1.288
+++ src/htmlclueflow.c	9 Oct 2003 12:39:50 -0000
@@ -604,6 +604,12 @@ set_painter (HTMLObject *o, HTMLPainter 
 }
 
 static guint
+get_length (HTMLObject *self)
+{
+	return get_recursive_length(self);
+}
+
+static guint
 get_indent (HTMLClueFlow *flow,
 	    HTMLPainter *painter)
 {
@@ -2238,6 +2244,7 @@ html_clueflow_class_init (HTMLClueFlowCl
 	object_class->get_recursive_length = get_recursive_length;
 	object_class->get_clear = get_clear;
 	object_class->set_painter = set_painter;
+	object_class->get_length = get_length;
 
 	klass->get_default_font_style = get_default_font_style;
 
Index: src/ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.1814.2.8
diff -u -p -r1.1814.2.8 ChangeLog
--- src/ChangeLog	15 Aug 2003 07:47:04 -0000	1.1814.2.8
+++ src/ChangeLog	9 Oct 2003 12:42:17 -0000
@@ -1,3 +1,8 @@
+2003-09-22  Antonio Xu  <antonio xu sun com>
+
+	* htmlclueflow.c (get_length) : add get_length to get the real
+	length of clueflow, fix buf #48753.
+
 2003-08-15  Antonio Xu  <antonio xu sun com>
 
 	* htmlengine-edit-movement.c (html_engine_jump_at): add


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]