Re: [evolution-patches] UTF8 conversion fix

[Not Zed <notzed ximian com>]

Look good, thanks!

On Thu, 2003-10-02 at 19:25, Frederic Crozat wrote:
> Le mer 01/10/2003 à 21:56, Jeffrey Stedfast a écrit :
> > 1. are we sure this isn't a glib2 bug? I would have thought that it
> > should give this to us in UTF-8 format...
>
> No, it is not.. glib2 is supposed to return gecos field without touching
> it..
>
> > assuming not:
> > 
> > 2. } else {
>
> Fixed.
>
> > 3. s/converted_name/utf8_name/ ? or maybe uname? something shorter would
> > be preferable to me.
>
> fixed with uname
>
> Reponding to NotZed :
> > I wonder, should it just do the conversion always from locale, if that
> > string is supposed to be in locale format?
> > Just simplifies the logic, not having to special case that.
>
> Well, I thought it could lead to problem trying to convert if current
> locale was already UTF-8 but after checking glib code, in that case, it
> checks if it is valid UTF8 and will do a strdup on the string if that
> case (otherwise, it returns NULL).
>
> So it is safe to always convert into UTF-8.. 
>
> New patch attached (and I think I'll have to fix all my similar patches
> in nautilus and gdm :)) and I've also simplified code a little bit..