Re: [evolution-patches] Patch to fix Bonobo Versioning in HEAD



On Sat, 2003-11-29 at 07:28, Rodney Dawes wrote:
> This patch changes all of the relevant .server files to add the
> BASE_VERSION of evolution to all of the OAFIIDs and IDLs that are
> evolution-specific. It also updates all of the code in evolution
> that references those OAFIIDs and IDLs that is still being compiled.
> It also updates all of the importers, even though they aren't being
> compiled, so that it will be easier to add them back in. The sooner
> that I commit this to HEAD (with appropriate ChangeLog entries), the
> sooner people can use 1.5 alongside 1.4 without having all kinds of
> weird issues with the wrong versions of components getting started.
> 
> --- calendar/gui/alarm-notify/notify-main.c	23 Nov 2003 17:29:05
-0000	1.31
> +++ calendar/gui/alarm-notify/notify-main.c	29 Nov 2003 06:21:20 -0000
> @@ -160,7 +160,7 @@
>  
>  	gnome_sound_init ("localhost");
>  
> -	factory = bonobo_generic_factory_new
("OAFIID:GNOME_Evolution_Calendar_AlarmNotify_2",
> +	factory = bonobo_generic_factory_new
("OAFIID:GNOME_Evolution_Calendar_AlarmNotify" BASE_VERSION,
>
here it seems to miss the ":" before BASE_VERSION.

It looks ok to me apart from this, and provided it doesn't affect
anything (ie, the "1.0" string in the repo_id is hard-coded by
orbit-idl, and I don't know if changing it in the .server files has any
effect. I suppose not)

cheers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]