On Enj , 2003-11-27 at 14:09, Grahame Bowland wrote: > Config dialog screenshot: > http://grahame.angrygoats.net/images/custom-mail-headers.png You shouldn't use a GtkFrame here. The grouping label should be bold, and the GtkTreeView should be spaced 12 pixels to the right, under the label. The grouping label should probably say "Displayed Mail _Headers" or something similar. The GtkScrolledWindow that contains the GtkTreeView should be GTK_SHADOW_IN, and the scrollbars should be set to GTK_POLICY_AUTOMATIC. The buttons should not be fill/expand in a GtkHBox that is fill/expand as well, and should be right-justified. The buttons should have their border_width set to 0. The Add button should probably say "Add _Header" instead. The GtkBoxes should have a spacing of 6. The main GtkVBox in the GtkNotebook page should have a border_width of 6, and all other GtkBoxes should have a border width of 0. The CheckBoxes in the GtkTreeView should be for setting the visibility of the header, not the usage of bold. I've made a mock-up of what a HIG-compliant version would look like, based on my comments above: http://primates.ximian.com/~dobey/screenshots/evolution-custom-mail-headers.png > Viewing a mail: > http://grahame.angrygoats.net/images/custom-mail-headers-view.png The header "names" should all be bold, as they are with From:, Date: and similar. This goes along with the previous comment of the CheckBoxes in the GtkTreeView being used for enable/disable instead of bold. Not sure if this is your patch, or evolution in general, but the mail header names should be nowrap so that X-Spam-Status and such don't get broken up, as they do in your screenshot. It looks much more natural and consistent if they didn't. The actual header content can wrap of course. That's all I have to say about it. Michael and Jeff can review the mail areas of the patch. -- dobey
Attachment:
signature.asc
Description: This is a digitally signed message part
