Re: [evolution-patches] Bug 46351, Calendar:Accesskey for Time_z_one doesn't work

[JP Rosevear <jpr ximian com>]

On Mon, 2003-11-24 at 02:43, Carl sun wrote:
> Hi, JP Rosevear,
> 
>      I am explaining why I add get_private_buttons accessor method  in
> my submitted patch:
>      As you known, "button"  is defined in the ETimezoneEntryPrivate,
> a private attribute of ETimezoneEntry.  The function 
> e_timezone_entry_mnemonic_activate (GtkWidget *widget,     gboolean 
> group_cycling) doesn't belong to member method of ETimezoneEntry.
> According to encapsulation and accessive mechanism of OO,  so I add
> the member method "get_private_buttons" to access the private
> attribute of ETimezoneEntry.
> 
>     Of course, I have tried deleting this accessor method, that is
> okay. but I don't think this way works better for the sake of  the
> complexity of access and breaking the encapsulation mechanism.
>    
>     It's up to you which way we can take. If the latter is much
> prefer, I will send the new version of patch to you. Waiting for your
> reply! 

Maybe I'm missing something - no where in this patch do you seem to call
the get_private_buttons accessor.  Is this going to be called from the
a11y directory?  Please note that the a11y patches are supposed to be
approved by one of the other a11y guys as well.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.