Re: [evolution-patches] please review the patch of #51187 (calendar)

[Rodrigo Moya <rodrigo ximian com>]

On Thu, 2003-11-20 at 07:31, jack jia wrote:
> Hi Rodrigo and JP:
> 
> Could you review the patch for bug #51187?
> http://bugzilla.ximian.com/show_bug.cgi?id=51187
> 
> Please notice my comments in src code.
> 
> in the  gui/alarm-notify/alarm-queue.c (obj_updated_cb).
> 
> 
> obj_updated_cb (..) 
> {
>         .....
>         cqa = lookup_comp_queued_alarms (ca, uid);
>         if (!cqa)
>                 add_component_alarms (ca, alarms);
>         else {
>                 GSList *l;
>                                                                                                                              
>                 /* if already in the list, just update it */
>                 remove_alarms (cqa, FALSE);
>                 cqa->alarms = alarms;
>                 cqa->queued_alarms = NULL;
>                 
>                 ....
> 
>                 cqa->queued_alarms = g_slist_prepend
> (cqa->queued_alarms, qa);
>                 // it want to reuse the cqa, but it will cause the
>                 // cqa->queued_alarms  NULL. and it will lead to
> evolution-alarm-notify's crash.
>                 // so i suggest not to reuse the cqa and remove it 
>                 // from ca, and then new a cqa and add it to ca.
>      
this will cause problems, I think, when snoozing, since the cqa is
reused because of that. That is, if you snooze an alarm, this is added
to the cqa as an alarm, so if you remove all of it, you lose that snooze
alarm. I guess it would be much better to detect the case where cqa is
NULL in this function.

cheers