Re: [evolution-patches] Re: patch for bug # 50538: atk table and atk selection impl. for e-calendar.

[Yuedong Du <yuedong du sun com>]

2 problems,

1. The implementation of ref_selection of selection interface seems not accurate,
see below.

+static AtkObject*  
+selection_interface_ref_selection (AtkSelection *selection, gint i)
+{
+	if (selection_interface_is_child_selected (selection, i))
+		return ea_calendar_item_ref_child (ATK_OBJECT (selection), i);
+	return NULL;
+}

It should return the ith child of selection. but the patch return the 
ith child of table.

2. And in e_calendar_item_get_offset_for_date(), it return FALSE when 
failed. While
the valid return value of this function is 0-11. So it is not proper. 
see below,

+gint
+e_calendar_item_get_offset_for_date (ECalendarItem *calitem,
+				     gint year, gint month, gint day)
+{
           ... ... ...
+
+	g_return_val_if_fail (E_IS_CALENDAR_ITEM (calitem), FALSE);
+
+	if (!e_calendar_item_get_date_range (calitem, &start_year,
+					     &start_month, &start_day,
+					     &end_year, &end_month,
+					     &end_day))
+		return FALSE;


Other parts look good.



-York

JP Rosevear wrote:

> On Tue, 2003-11-04 at 05:23, Bolian Yin wrote: 
>  
>
> > Hi,
> >
> > another a11y patch for e-calendar:  atk table and atk selection impl.
> > for e-calendar.
> > bug 50538: http://bugzilla.ximian.com/show_bug.cgi?id=50538
> >
> > Most of changes are in evolution/a11y/widgets
> >    
>
> Approved pending review by another Sun a11y hacker.
>
> -JP 
>
>