[evolution-patches] patch for #43763



This makes the code use again g_signal_connect_after for the
"button_press_event" on the top canvas. This was changed by JP to
g_signal_connect for fixing #43103.

With this fix, I can't replicate #43103, so I imagine it doesn't affect
it to use again connect_after. JP?
Index: gui/e-day-view.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-day-view.c,v
retrieving revision 1.194
diff -u -p -r1.194 e-day-view.c
--- gui/e-day-view.c	19 May 2003 15:21:43 -0000	1.194
+++ gui/e-day-view.c	29 May 2003 14:45:20 -0000
@@ -620,8 +620,8 @@ e_day_view_init (EDayView *day_view)
 	gtk_table_attach (GTK_TABLE (day_view), day_view->top_canvas,
 			  1, 2, 0, 1, GTK_EXPAND | GTK_FILL, GTK_FILL, 0, 0);
 	gtk_widget_show (day_view->top_canvas);
-	g_signal_connect (day_view->top_canvas, "button_press_event",
-			  G_CALLBACK (e_day_view_on_top_canvas_button_press), day_view);
+	g_signal_connect_after (day_view->top_canvas, "button_press_event",
+				G_CALLBACK (e_day_view_on_top_canvas_button_press), day_view);
 	g_signal_connect (day_view->top_canvas, "button_release_event",
 			  G_CALLBACK (e_day_view_on_top_canvas_button_release), day_view);
 	g_signal_connect (day_view->top_canvas, "motion_notify_event",
Index: gui/e-week-view.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/e-week-view.c,v
retrieving revision 1.163
diff -u -p -r1.163 e-week-view.c
--- gui/e-week-view.c	19 May 2003 15:21:43 -0000	1.163
+++ gui/e-week-view.c	29 May 2003 14:45:23 -0000
@@ -382,14 +382,14 @@ e_week_view_init (EWeekView *week_view)
 				       "EWeekViewMainItem::week_view", week_view,
 				       NULL);
 
-	g_signal_connect (week_view->main_canvas, "button_press_event",
+	g_signal_connect_after (week_view->main_canvas, "button_press_event",
 				G_CALLBACK (e_week_view_on_button_press), week_view);
 	g_signal_connect (week_view->main_canvas, "button_release_event",
-				G_CALLBACK (e_week_view_on_button_release), week_view);
+			  G_CALLBACK (e_week_view_on_button_release), week_view);
 	g_signal_connect (week_view->main_canvas, "scroll_event",
-				G_CALLBACK (e_week_view_on_scroll), week_view);
+			  G_CALLBACK (e_week_view_on_scroll), week_view);
 	g_signal_connect (week_view->main_canvas, "motion_notify_event",
-				G_CALLBACK (e_week_view_on_motion), week_view);
+			  G_CALLBACK (e_week_view_on_motion), week_view);
 
 	/* Create the buttons to jump to each days. */
 	pixbuf = gdk_pixbuf_new_from_xpm_data ((const char**) jump_xpm);
@@ -2266,7 +2266,7 @@ e_week_view_on_button_press (GtkWidget *
 		e_week_view_show_popup_menu (week_view, event, -1);
 	}
 
-	return FALSE;
+	return TRUE;
 }
 
 
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.1785
diff -u -p -r1.1785 ChangeLog
--- ChangeLog	29 May 2003 09:05:57 -0000	1.1785
+++ ChangeLog	29 May 2003 14:45:40 -0000
@@ -1,3 +1,12 @@
+2003-05-29  Rodrigo Moya <rodrigo ximian com>
+
+	Fixes #43763
+
+	* gui/e-week-view.c (e_week_view_init): use g_signal_connect_after
+	for "button_press_event" callback.
+
+	* gui/e-day-view.c (e_day_view_init): ditto.
+
 2003-05-28  Rodrigo Moya <rodrigo ximian com>
 
 	Fixes #43455


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]