Re: [evolution-patches] Re: 43485: strftime usage in e-cell-date
- From: Mike Kestner <mkestner ximian com>
- To: Jeffrey Stedfast <fejj ximian com>
- Cc: patches <evolution-patches ximian com>
- Subject: Re: [evolution-patches] Re: 43485: strftime usage in e-cell-date
- Date: 23 May 2003 13:44:37 -0500
On Fri, 2003-05-23 at 13:44, Jeffrey Stedfast wrote:
> +
> + fmt = e_utf8_to_locale_string (fmt);
> + e_strftime_fix_am_pm (buf, 26, fmt, &then);
> + g_free (fmt);
>
> why make buf 26 bytes? do we know for a fact that 26 is plenty for all
> locales? (I know you didn't do this as part of the patch, just bringing
> this up because I noticed it already there).
One in a series of magic numbers throughout etable. I do not know it
"for a fact." Based on the format strings in the patch, what number
would you suggest?
> I presume that buf later gets transformed back into UTF-8, yes?
Yep.
Mike
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]