Re: [evolution-patches] typo fix

[Larry Ewing <lewing ximian com>]

I was worried I was a little hasty with this patch and sure enough
here is a proper fix.

On Tue, 2003-05-20 at 15:21, Larry Ewing wrote:
> This fixes a typo in htmlimage.c that caused a warning.
> 
> --Larry

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v
retrieving revision 1.1807
diff -u -p -r1.1807 ChangeLog
--- ChangeLog	20 May 2003 18:25:14 -0000	1.1807
+++ ChangeLog	21 May 2003 01:20:10 -0000
@@ -1,5 +1,8 @@
 2003-05-20  Larry Ewing  <lewing ximian com>
 
+	* htmlimage.c (html_image_resolve_image_url): unset oarg not iarg
+	and dup the string.
+
 	* gtkhtml.h: add prototypes.
 
 	* htmlengine-edit-cut-and-paste.c (use_pictograms): use get_magic_smileys.
Index: htmlimage.c
===================================================================
RCS file: /cvs/gnome/gtkhtml/src/htmlimage.c,v
retrieving revision 1.186
diff -u -p -r1.186 htmlimage.c
--- htmlimage.c	20 May 2003 15:17:13 -0000	1.186
+++ htmlimage.c	21 May 2003 01:20:11 -0000
@@ -489,14 +489,14 @@ html_image_resolve_image_url (GtkHTML *h
 		GValue  *oarg;
 
 		g_value_init (iarg, G_TYPE_STRING);
-		g_value_set_string (iarg, image_url);
+		g_value_set_static_string (iarg, image_url);
 
 		oarg = (* html->editor_api->event) (html, GTK_HTML_EDITOR_EVENT_IMAGE_URL, iarg, html->editor_data);
 
 		if (oarg) {
 			if (G_VALUE_TYPE (oarg) == G_TYPE_STRING)
-				url = (gchar *) g_value_get_string (oarg);
-			g_value_unset (iarg);	
+				url = (gchar *) g_strdup (g_value_get_string (oarg));
+			g_value_unset (oarg);	
 			g_free (oarg);
 		}
 		g_value_unset (iarg);