Re: [evolution-patches] composer settings

[Jeffrey Stedfast <fejj ximian com>]

looks okay

Jeff

On Tue, 2003-05-20 at 14:07, Larry Ewing wrote:
> On Tue, 2003-05-20 at 12:43, Jeffrey Stedfast wrote:
> > er, this probably applies to the patch I just commented on a few minutes
> > ago - but is it really necessary to g_object_unref() the gconf object? I
> > don't think you are supposed to do that? I got the impression that
> > gconf_client_get_default() did not return a ref'd object.
> > 
> 
> Your impression is wrong, ir refs on every return.  We are leaking refs
> like mad, but since there is only one of them it probably isn't that big
> of a deal.
> 
> > if we are supposed to unref it, I guess the mailer leaks references to
> > it all over the place.
> > 
> > anyways, other than that, this patch looks okay.
> > 
> 
> Somehow I left out a 
> 
> gconf_client_add_dir (gconf, "/apps/evolution/mail/composer", GCONF_CLIENT_PRELOAD_ONELEVEL, NULL);
> 
> at e-msg-composer.c:2977
> 
> fixed patch included.
> 
> --Larry
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com