Re: [evolution-patches] calendar patch for 42046

[Anna Marie Dirks <anna ximian com>]

Committed with the following change: 

* instead of including gkt.h , include gtkmessagedialog.h and
gtkstock.h.  

cheers, Anna





On Tue, 2003-05-20 at 07:11, Rodrigo Moya wrote:
> On Tue, 2003-05-20 at 00:38, Anna Marie Dirks wrote:
> > So, this patch HIG-ifies the "Do you want to save changes?" dialog which
> > is associated with tasks and appointments. Basically, it replaces the
> > (deprecated, ugly) gnome_message_box with a gtk_mesage_dialog. It fixes
> > bug #42046.
> > 
> > I am not sure if you guys will want me to apply this or not, though,
> > because: 
> > 
> > * It breaks string freeze-- though I suppose I could change the text so
> > it doesn't. 
> > * It involves a fair amount of AnnaHacking, which is hardly my forte.
> > (though really, this was mostly AnnaCopyingAndPasting, so it could be
> > worse.)
> > 
> > On the other hand: 
> > 
> > * It does seem to work in all instances (I tested it a lot)
> > * It fixes a wretched dialog.
> > 
> > Oh also: 
> > 
> > * When you (attempt to) close the appt editor's window w/o saving
> > changes, the window goes behind the main evo window. I checked, and this
> > happens with the currently-in-cvs code, as well as with my patch. I
> > sense that there is another problem somewhere involving keeping that
> > window on top which should, someday, be fixed.
> > 
> > So let me know what you think.
> > Anna
> > 
>  #include <glib.h>
>  #include <libgnome/gnome-i18n.h>
> -#include <libgnomeui/gnome-messagebox.h>
> -#include <libgnomeui/gnome-stock-icons.h>
>  #include <gal/widgets/e-unicode.h>
> +#include <gtk/gtk.h>
>  #include "save-comp.h"
> 
> here, we usually include the individual GTK header files, instead of the
> main gtk.h. It's not important at all, but it speeds up compilation if
> you just use the needed headers.
> 
> Apart from that, it looks ok.
> 
> cheers
-- 
Anna Marie Dirks <anna ximian com>