Re: [evolution-patches] Patch for shell crash (#43322)

[Mike Kestner <mkestner ximian com>]

Your ChangeLog indicates that in shell_view_weak_notify you are setting
parent = NULL, but your patch does not show such a change since it is
already being set to NULL in that func in cvs trunk. The discrepancy got
me interested enough to wonder why shell_view_weak_notify does not call
cleanup_discovery like the other notify callbacks do.  :)

Otherwise, the patch looks good with that small ChangeLog change. 

On Mon, 2003-05-19 at 17:43, Ettore Perazzoli wrote:
> +
> +	* e-shell-shared-folder-picker-dialog.c (storage_weak_notify): Set
> +	the storage member to NULL.
> +	(shell_view_weak_notify): Set the parent member to NULL.
> +	(shell_weak_notify): Set the shell member to NULL.
> +	(cleanup_discovery): g_object_weak_unref() shell, parent and
> +	storage.