Re: [evolution-patches] 43234, mail-display fetch_cancel() patch

[Not Zed <notzed ximian com>]

This patch should address the source of the problem - we were getting an
async 'message loaded' callback after the mail-display had already been
destroyed, which called mail_display_set_message.

so later when destroy handler is called again, it finds a
current_message to clear up, mail_display->priv no longer exists =>
crash.

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.2727
diff -u -3 -r1.2727 ChangeLog
--- ChangeLog	18 May 2003 20:20:28 -0000	1.2727
+++ ChangeLog	19 May 2003 14:57:06 -0000
@@ -1,3 +1,10 @@
+2003-05-20  Not Zed  <notzed lostzed mmc com au>
+
+	** See bug #43234
+	
+	* mail-display.c (mail_display_set_message): if we've been
+	destroyed, noop.
+
 2003-05-17  Larry Ewing  <lewing ximian com>
 
 	* GNOME_Evolution_Mail.server.in.in: remove font prefs server from
Index: mail-display.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-display.c,v
retrieving revision 1.277
diff -u -3 -r1.277 mail-display.c
--- mail-display.c	14 May 2003 18:47:10 -0000	1.277
+++ mail-display.c	19 May 2003 14:57:07 -0000
@@ -1964,7 +1965,8 @@
 	/* For the moment, we deal only with CamelMimeMessage, but in
 	 * the future, we should be able to deal with any medium.
 	 */
-	if (medium && !CAMEL_IS_MIME_MESSAGE (medium))
+	if (md->destroyed
+	    || (medium && !CAMEL_IS_MIME_MESSAGE (medium)))
 		return;
 	
 	/* Clean up from previous message. */