Re: [Fwd: Re: [evolution-patches] propsed patch for 38084 [Contacts]]

[Chris Toshok <toshok ximian com>]

well, it wouldn't cause too much of a performance hit to move the file,
but you have complicate the code a bit more - it shouldn't cause a
failure if we couldn't duplicate the summary file but could move the
actual db.

So, removing the summary seems like an ok solution.

Chris

On Mon, 2003-05-12 at 05:22, Sean Gao wrote:
> From: Sean Gao <sean gao sun com>
> To: Chris Toshok <toshok ximian com>
> Subject: Re: [evolution-patches] propsed patch for 38084 [Contacts]
> Date: 12 May 2003 18:25:47 +0800
> 
> Of course it is ok to solve it  as following :
> 
> +if (result ==GNOME_Evolution_ShellComponentListener_OK)
> +    result = xfer_file (src_uri, dest_uri, "addressbook.db.summary", 
> remove_source);
> 
> but in fact I do not think it is necessary to copy the 
> "addressbook.db.summary" to destination directory,
> thus calling xfer_file() will cause some performance loss.
> 
> Anyway,  the aim is to remove the summary file in the source directory.
> 
> Thanks,
> -Sean
> 
> Chris Toshok wrote:
> 
> >why not move the summary as well?
> >
> >On Mon, 2003-05-12 at 01:19, Sean Gao wrote:
> >  
> >
> >>Hi There,
> >>    I have an investigation about this issue and find that the reason 
> >>for this problem is that
> >>the "summary" file in the oriiginal folder is not removed.  Therefore I 
> >>write this proposed
> >>patch, it works for me. Please help to have a look.
> >>
> >>Thanks,
> >>-Sean
> >>
> >>______________________________________________________________________
> >>Index: addressbook-component.c
> >>===================================================================
> >>RCS file: /cvs/gnome/evolution/addressbook/gui/component/addressbook-component.c,v
> >>retrieving revision 1.86
> >>diff -u -r1.86 addressbook-component.c
> >>--- addressbook-component.c	5 Mar 2003 02:05:34 -0000	1.86
> >>+++ addressbook-component.c	12 May 2003 08:08:42 -0000
> >>@@ -344,6 +344,14 @@
> >> 
> >> 	result = xfer_file (src_uri, dest_uri, "addressbook.db", remove_source);
> >> 	
> >>+	if ((result == GNOME_Evolution_ShellComponentListener_OK) && (remove_source)) {
> >>+		char *summary_uri;
> >>+
> >>+		summary_uri = g_strconcat (source_physical_uri, "/addressbook.db.summary", NULL);
> >>+		result = gnome_vfs_unlink (summary_uri);
> >>+		g_free (summary_uri);
> >>+	}
> >>+
> >> 	GNOME_Evolution_ShellComponentListener_notifyResult (listener, result, &ev);
> >> 
> >> 	gnome_vfs_uri_unref (src_uri);
> >>    
> >>
> >_______________________________________________
> >Evolution-patches mailing list
> >Evolution-patches lists ximian com
> >http://lists.ximian.com/mailman/listinfo/evolution-patches
> >  
> >
> 
>