[evolution-patches] summary patch for #41135

[Anna Marie Dirks <anna ximian com>]

This patch fixes up (HIG-ifies) the layout of the "New News Feed"
dialog, by packing it into a table instead of a hboxes. Also, I noticed
that there was an "Invalid cast" warning being printed on the command
line when I tested this, so I took the liberty of correcting it.
(someone was accidentally casting a gtk_dialog to a gnome_dialog..) 

Given that my c-hacking skills are shaky at best, I'd appreciate being
told if I correctly respected your style guidelines, etc. 

cheers,
Anna

-- 
Anna Marie Dirks <anna ximian com>

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/my-evolution/ChangeLog,v
retrieving revision 1.286
diff -u -u -w -r1.286 ChangeLog
--- ChangeLog	16 May 2003 18:10:29 -0000	1.286
+++ ChangeLog	16 May 2003 18:55:31 -0000
@@ -1,3 +1,13 @@
+2003-05-16  Anna Marie Dirks  <anna ximian com>
+
+	* e-summary-preferences.c (rdf_new_url_clicked_cb): This patch 
+	HIG-ifies the "New News Feed" dialog, by using a table with 
+	appropriate spacing instead of hboxes. Also fixes an invalid cast
+	of gtk_dialog->gnome_dialog.
+
+	* my-evolution.glade: HIG-ified this dialog by adding proper
+	spacing/padding/stock buttons/etc. Fixes bugs #41131, #41133.
+
 2003-05-16  Ettore Perazzoli  <ettore ximian com>
 
 	* e-summary.c (destroy): Remove the weak pointer on priv->control.
Index: e-summary-preferences.c
===================================================================
RCS file: /cvs/gnome/evolution/my-evolution/e-summary-preferences.c,v
retrieving revision 1.85
diff -u -u -w -r1.85 e-summary-preferences.c
--- e-summary-preferences.c	16 Apr 2003 14:44:14 -0000	1.85
+++ e-summary-preferences.c	16 May 2003 18:55:31 -0000
@@ -559,10 +559,10 @@
 			PropertyData *pd)
 {
 	GtkWidget *add_dialog;
-	GtkWidget *label, *hbox;
+	GtkWidget *name_label, *url_label, *table;
 	GtkWidget *new_name_entry, *new_url_entry;
 
-	add_dialog = gtk_dialog_new_with_buttons (_("Add a news feed"),
+	add_dialog = gtk_dialog_new_with_buttons (_("New News Feed"),
 						  GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (button))),
 						  GTK_DIALOG_DESTROY_WITH_PARENT,
 						  GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
@@ -570,22 +570,22 @@
 						  NULL);
 	gtk_dialog_set_default_response (GTK_DIALOG (add_dialog), GTK_RESPONSE_OK);
 
-	label = gtk_label_new (_("Enter the URL of the news feed you wish to add"));
-	gtk_box_pack_start (GTK_BOX (GNOME_DIALOG (add_dialog)->vbox), label,
-			    TRUE, TRUE, 0);
-	hbox = gtk_hbox_new (FALSE, 2);
-	label = gtk_label_new (_("Name:"));
-	gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
+	table = gtk_table_new (2, 2, FALSE);
+
+	name_label = gtk_label_new_with_mnemonic (_("_Name:"));
+       	gtk_table_attach (GTK_TABLE (table), name_label, 0, 1, 0, 1, GTK_FILL, 0, 6, 6);
+
 	new_name_entry = gtk_entry_new ();
-	gtk_box_pack_start (GTK_BOX (hbox), new_name_entry, TRUE, TRUE, 0);
-	gtk_box_pack_start (GTK_BOX (GNOME_DIALOG (add_dialog)->vbox), hbox, TRUE, TRUE, 3);
+	gtk_table_attach (GTK_TABLE (table), new_name_entry, 1, 2, 0, 1, GTK_EXPAND | GTK_FILL, 0, 6, 6);
+
+	url_label = gtk_label_new_with_mnemonic (_("_URL:"));
+	gtk_table_attach (GTK_TABLE (table), url_label, 0, 1, 1, 2, GTK_FILL, 0, 6, 6);
 
-	hbox = gtk_hbox_new (FALSE, 2);
-	label = gtk_label_new (_("URL:"));
 	new_url_entry = gtk_entry_new ();
-	gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
-	gtk_box_pack_start (GTK_BOX (hbox), new_url_entry, TRUE, TRUE, 0);
-	gtk_box_pack_start (GTK_BOX (GNOME_DIALOG (add_dialog)->vbox), hbox, TRUE, TRUE, 3);
+	gtk_table_attach (GTK_TABLE (table), new_url_entry, 1, 2, 1, 2, GTK_EXPAND | GTK_FILL, 0, 6, 6);
+
+
+	gtk_box_pack_start (GTK_BOX (GTK_DIALOG (add_dialog)->vbox), table, FALSE, FALSE, 6);
 	gtk_widget_show_all (add_dialog);
 
 	if (gtk_dialog_run (GTK_DIALOG (add_dialog)) == GTK_RESPONSE_OK) {