Re: [evolution-patches] gtkhtml: printing fix

[Dan Winship <danw ximian com>]

On Fri, 2003-05-16 at 09:32, Radek Doulík wrote:
> Attached patch enlarges page margins and contains updates for changed
> descender sign (it's negative value in gnome 2 gnome print)

Hm. There's some weird code in htmlprinter.c.

printer_get_page_width is calling gnome_print_convert_distance, but
printer_get_page_height is not. I imagine one of them must be wrong.

get_tmargin and get_bmargin are calling printer_get_page_width instead
of printer_get_page_height. But more generally, the idea of making the
margins a fixed percentage of the page size instead of a fixed size
seems wrong. (If you do change get_tmargin and get_bmargin to call
get_page_height instead of width, then we'd end up with .5" left/right
margins but .66" top/bottom margins.)

gedit calls gnome_print_config_get_length (config,
GNOME_PRINT_KEY_PAGE_MARGIN_LEFT, &margin, NULL), etc to get the
margins, but it also seems to end up with margins that are way too big.
:-/

-- Dan