[evolution-patches] Please check in my patch for bug #42491



 Hello Ettore,
        Since Fejj said I should ask you to check in this patch, so I send my requestion to you.
        Could you checked the fix into trunk?

Thanks
Antonio Xu

Not Zed wrote:
Hrm, i actually did that stuff wrong, what i intended to do was have it
static.

The fix looks ok.

Boy, forte is stupidly anal about warnings ... (at least, the strcmp
ones with xml node names).

On Fri, 2003-05-09 at 05:29, Ettore Perazzoli wrote:
  
Looks good (although the ChangeLog entry is misleading; what you
actually fixed is the "const struct", not the "char *").

On Thu, 2003-05-08 at 06:22, Antonio Xu wrote:
    
Hello All,
               Could you review my patch for bug #42491?
               Bug Summary:Build Evolution error (May 6 trunk)
               Bug Description: When building evolution (May 6 trunk) on 
Solaris 8/9 with Forte, system report error.

Thanks
Antonio Xu
      
-- Ettore
_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
    

_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
  


Index: e-config-upgrade.c
===================================================================
RCS file: /cvs/gnome/evolution/shell/e-config-upgrade.c,v
retrieving revision 1.9
diff -u -r1.9 e-config-upgrade.c
--- e-config-upgrade.c	29 Apr 2003 02:40:56 -0000	1.9
+++ e-config-upgrade.c	8 May 2003 09:24:17 -0000
@@ -617,8 +617,8 @@
 {
 	const char *value_tags[] = { "string", "address", "regex", "file", "command", NULL };
 	const char *rule_tags[] = { "title", NULL };
-	const struct {
-		char *name;
+	struct {
+		const char *name;
 		const char **tags;
 	} tags[] = {
 		{ "value", value_tags },
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/shell/ChangeLog,v
retrieving revision 1.1266
diff -u -r1.1266 ChangeLog
--- ChangeLog	5 May 2003 01:12:39 -0000	1.1266
+++ ChangeLog	8 May 2003 09:27:01 -0000
@@ -1,3 +1,8 @@
+2003-05-02  Antonio Xu  <antonio xu sun com>
+
+	* e-config-upgrade.c (upgrade_xml_1_2_rec): using const char *name
+	instead of char *name.
+ 
 2003-05-02  Not Zed  <NotZed Ximian com>
 
 	* e-shell-about-box.c (text[]): grepped changelogs and added all



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]