[evolution-patches] 42838 crash setting up local account



I really dont know why this doesn't also affect other account types, but
maybe its just a side effect of not-side-effect-free code.


Index: mail/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.2722
diff -u -3 -r1.2722 ChangeLog
--- mail/ChangeLog	13 May 2003 16:12:10 -0000	1.2722
+++ mail/ChangeLog	15 May 2003 00:31:38 -0000
@@ -1,3 +1,10 @@
+2003-05-15  Not Zed  <NotZed Ximian com>
+
+	** See bug #42838.
+
+	* mail-account-gui.c (mail_account_gui_build_extra_conf): always
+	add the extra entry to the hash table, most paths wouldn't.
+
 2003-05-13  Ettore Perazzoli  <ettore ximian com>
 
 	* component-factory.c (segv_redirect): Removed.
Index: mail/mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.129
diff -u -3 -r1.129 mail-account-gui.c
--- mail/mail-account-gui.c	25 Mar 2003 15:49:19 -0000	1.129
+++ mail/mail-account-gui.c	15 May 2003 00:31:39 -0000
@@ -900,7 +900,6 @@
 				label = gtk_label_new (entries[i].text);
 				gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.0);
 				entry = gtk_entry_new ();
-				g_hash_table_insert (gui->extra_config, entries[i].name, entry);
 				
 				gtk_table_attach (cur_table, label, 0, 1, rows, rows + 1,
 						  GTK_FILL, 0, 0, 0);
@@ -908,7 +907,7 @@
 						  GTK_EXPAND | GTK_FILL, 0, 0, 0);
 				rows++;
 			}
-			
+
 			if (url)
 				text = camel_url_get_param (url, entries[i].name);
 			else
@@ -921,7 +920,9 @@
 				setup_toggle (entry, entries[i].depname, gui);
 				setup_toggle (label, entries[i].depname, gui);
 			}
-			
+
+			g_hash_table_insert (gui->extra_config, entries[i].name, entry);
+						
 			break;
 		}
 		


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]