[evolution-patches] 42622: crash editing e-cell-text



valgrind output from tim makes it look like the problem is a
post-dispose invocation of eti_event.  This patch adds <cringe> a
dispose check to eti_event </cringe> as a workaround.

Wish we could test this first, but I think tim needs it in snap form to
retest.

Mike
Index: gal/e-table/ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/gal/e-table/ChangeLog,v
retrieving revision 1.895
diff -u -p -r1.895 ChangeLog
--- gal/e-table/ChangeLog	9 May 2003 21:39:56 -0000	1.895
+++ gal/e-table/ChangeLog	13 May 2003 22:46:05 -0000
@@ -1,3 +1,8 @@
+2003-05-13  Mike Kestner  <mkestner ximian com>
+
+	* e-table-item.c (eti_event): gross hack to work around a
+	post dispose event emission by gtk2.0/canvas2.0 [#42622]
+
 2003-05-09  Mike Kestner  <mkestner ximian com>
 
 	* e-tree.c (find_next_in_range): add null check for paths
Index: gal/e-table/e-table-item.c
===================================================================
RCS file: /cvs/gnome/gal/gal/e-table/e-table-item.c,v
retrieving revision 1.221
diff -u -p -r1.221 e-table-item.c
--- gal/e-table/e-table-item.c	9 May 2003 17:14:17 -0000	1.221
+++ gal/e-table/e-table-item.c	13 May 2003 22:46:07 -0000
@@ -2233,6 +2233,9 @@ eti_event (GnomeCanvasItem *item, GdkEve
 	gboolean leave = FALSE;
 #endif
 
+	if (!eti->header)
+		return FALSE;
+
 	switch (e->type){
 	case GDK_BUTTON_PRESS: {
 		double x1, y1;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]