Re: [evolution-patches] Yet more 64bit cleanups



On Wed, 2003-05-07 at 17:29, Jeremy Katz wrote:
> It cleans up some warnings and I was on a roll with them :) 
> 
> Since you're using a GtkTreeView, you generally want to use a
> GtkTreeStore instead of a GtkListStore.  Additionally, the GtkTreeModel
> is an interface and isn't usually what you directly instantiate.

Fixing the warnings is good, but I don't see a reason to use a
GtkTreeStore since it is actually displaying a list and not a tree. 
GtkTreeView is meant to work with either anyways...

And even if you change it to use a GtkTreeStore, you also need to fix
update_dialog_tree_view_hash_foreach(), which expects a GtkListStore.

(Also, what do you mean with the instantiation of GtkTreeModel?  The
existing code doesn't instantiate GtkTreeModel, it instantiates
GtkTreeStore.)

-- Ettore



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]