Re: [evolution-patches] another fix for 42038

[Jeffrey Stedfast <fejj ximian com>]

looks good to me.

Jeff

On Thu, 2003-05-01 at 22:29, Not Zed wrote:
> instead of crashing, just assume any unknown response is equivalent
> cancel, rather than trying to deal with all possibilities explictly. -
> another one was missed in the last patch.
> 
> 
> ______________________________________________________________________
> Index: e-util/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/e-util/ChangeLog,v
> retrieving revision 1.386
> diff -u -3 -r1.386 ChangeLog
> --- e-util/ChangeLog	30 Apr 2003 19:47:16 -0000	1.386
> +++ e-util/ChangeLog	2 May 2003 01:19:41 -0000
> @@ -1,3 +1,9 @@
> +2003-05-02  Not Zed  <NotZed Ximian com>
> +
> +	* e-request.c (e_request_string): remove the assert, if we dont
> +	understand the response, assume it's a cancel.
> +	GTK_RESPONSE_DELETE_EVENT wasn't handled [#42038].
> +
>  2003-04-30  Ettore Perazzoli  <ettore ximian com>
>  
>  	* e-request.c (e_request_string): Handle GTK_RESPONSE_NONE.
> Index: e-util/e-request.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/e-util/e-request.c,v
> retrieving revision 1.11
> diff -u -3 -r1.11 e-request.c
> --- e-util/e-request.c	30 Apr 2003 19:47:16 -0000	1.11
> +++ e-util/e-request.c	2 May 2003 01:19:41 -0000
> @@ -91,12 +91,9 @@
>  	case GTK_RESPONSE_OK:
>  		text = g_strdup (gtk_entry_get_text (GTK_ENTRY (entry)));
>  		break;
> -	case GTK_RESPONSE_CANCEL:
> -	case GTK_RESPONSE_NONE:
> +	default:
>  		text = NULL;
>  		break;
> -	default:
> -		g_assert_not_reached ();
>  	}
>  
>  	gtk_widget_destroy (dialog);
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com