Re: [evolution-patches] Re: gal cygwin patch

[Jeffrey Stedfast <fejj ximian com>]

where/why are people using gal on win32???

Jeff

On Thu, 2003-05-01 at 11:05, Mike Kestner wrote:
> Masahiro,
> 
> Thanks for the patch.  We're in patch review mode for evolution right
> now, so I'm posting your patch for our review process.  It looks okay to
> me.  Obviously we need a real fix for the gal-a11y-e-cell-text.c
> bandaid. I opened bug #42207 to make sure those functions get added to
> e-cell-text eventually, but your #defines are okay for now.
> 
> Please hold off for 24 hours to see if anyone else has feedback before
> committing.
> 
> Thanks,
> Mike
> 
> On Wed, 2003-04-23 at 13:23, Masahiro Sakai wrote:
> > Hi Mike,
> > 
> > I made a patch for compiling gal on cygwin.
> > http://web.sfc.keio.ac.jp/~s01397ms/cygwin/gal-1.99.2-2.patch
> > 
> > The -no-undefined stuff is what we want to be using, and
> > addition/re-ordering of LIBADD is good to have for several
> > platforms.
> > 
> > May I commit this patch?
> > 
> > Changes:
> > 
> > 	* configure.in: call AC_LIBTOOL_WIN32_DLL which is necessary for
> > 	building DLL on win32 platform.
> > 
> > 	* gal/Makefile.am: (libgal_2_0_la_LDFLAGS):
> > 	* gal/a11y/Makefile.am (libgal_a11y_2_0_la_LDFLAGS): add -no-undefined
> > 	which is necessary for building DLL on win32 platform.
> > 
> > 	* gal/a11y/e-table/gal-a11y-e-cell-text.c: stop calling undefined
> > 	functions e_cell_text_get_selection() and e_cell_text_set_selection().
> > 
> > 	* gal/a11y/Makefile.am (libgal_a11y_2_0_la_LIBADD):
> > 	add $(top_builddir)/gal/libgal-2.0.la and $(EXTRA_GNOME_LIBS).
> > 
> > 	* gal/Makefile.am: 
> > 	(libgal_2_0_la_LIBADD): add $(EXTRA_GNOME_LIBS).
> > 	(ui_subdirs): add "." ahead of "a11y". because above change make
> > 	a11y/libgal-a11y-2.0.la to depend on libgal-2.0.la.
> > 
> > 	* gal/widgets/Makefile.am (test_color_LDADD,
> > 	test_e_font_LDADD, test_font_loading_LDADD): fix ordering.
> > 	$(EXTRA_GNOME_LIBS) should be behind other libraries that depend on it.
> > 
> > Thanks,
> > 
> > -- Masahiro Sakai
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com