Re: [evolution-patches] Re: soup redirection patch

[Joe Shaw <joe ximian com>]

On Fri, 2003-03-28 at 16:40, Joe Shaw wrote:
> On Fri, 2003-03-28 at 16:32, Dan Winship wrote:
> > soup currently goes into an infinite loop if you redirect it to another
> > machine (at least if you're using NTLM auth. Maybe it doesn't happen
> > with normal auth?)
> 
> I don't think this a problem with regular auth, but it's definitely a
> problem with tunnelled HTTPS connections through proxies.  I think this
> patch will fix that problem as well, so it looks good.

Ack.  Turns out I wasn't quite right, this won't fix the HTTPS
connections... they have a problem with the pooled connections when
Keep-Alive is one.

One additional thing about the patch, though, you should check to make
sure that the old context is not NULL and not cleanup if it is.  The
server code creates a SoupMessage with a NULL context and then generates
a context based on the Host header and setting it using
soup_message_set_context().

something like:

if (msg->connection && msg->context &&
    (!new_ctx || (msg->context->server != new_ctx->server)))

should do.

Joe