[evolution-patches] Re: seek

[Gilbert Fang <gilbert fang sun com>]

Oh, yes, I will do these change at once , thank you very much 
Gilbert 



Chris Toshok wrote:

I was under the impression that the exporter was going to be one source file.� Since it's multiple source files I'm going to stick it into a subdirectory off tools/.� After some thought I've decided against the addressbook/tools directory.� No need to correct that in future patches though, I'll do the rearranging.

Some comments:

evolution-addressbook-exporter.h:

• rename to evolution-addressbook-export.h
• should be guarded against multiple inclusion with #ifdef/#endif

main.c:

• use GNOME_BONOBO_MODULE instead of LIBGNOMEUI_MODULE, and get rid of init_bonobo().

list-cards.c:

• don't use N_() for csv_name fields in ECardCSVFieldData.
• above escape_string there's a comment: "* this function is not needed in gnome2 because of g_strescape() has been enhanded to do so". Is escape_string needed anymore?

General:

• don't use g_error - it calls abort().� having a program call abort() for anything other than an exceptional condition in the code isn't acceptable.� use g_warning/g_message/printf and exit.
• there shouldn't be a --addressbook-folder flag.� The uri should be specified on the command line without aswitch.� Also, the uri should be optional and should default to the default addressbook if it's missing.
• fix compiler warnings (unused variables, some of the EBook callbacks have the wrong types, etc.)
• include the GPL boilerplate.
• includ the following line as the first line in the file:

/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*- */

• indent everything so that it matches the rest of the addressbook (probably the rest of evolution.)� Also, use:

��� if (condition) {
��� }

instead of:

��� if (condition)
����� {
����� }

On Wed, 2003-03-26 at 03:28, Gilbert Fang wrote:

Hi, Chris and Ettore

  I have created a new  patch which put the source codes in 
<top_level>/addressbook/tools.

  I also file a bug in bugzilla,  
http://bugzilla.ximian.com/show_bug.cgi?id=23036  , please review it and 
give me suggestion how to modify or check it in the trunk.

  Berry ( a staroffice developer) has finish their part of code and the 
staroffice can  access evolution addressbook now.  If the evolution has 
no these part of codes,  The coming version staroffice can not has the 
feature to access the evo addressbook and the next version will be a 
long time.
 
  So I am very eager to see your feedback.