Re: [evolution-patches] etree patch



On Fri, 2003-06-27 at 14:49, Dan Winship wrote:
> <soapbox>Using g_new rather than g_new0 to initialize priv structures is
> evil</soapbox>

I agree. I like init funcs that just init the non-zero stuff.

As far as the patch goes, the row_inserted and row_deleted signals are
no longer attached, so it would probably be cleaner to remove all
references to them.  Otherwise, looks fine.

Thanks.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]