Re: [evolution-patches] Patch to enable cursor and keyboard navigation in mail reader,(v7), menu version, please revoke previous ones

[Larry Ewing <lewing ximian com>]

This was already before you sent your message.

--Larry

On Fri, 2003-06-27 at 02:35, yuedong du wrote:
> Found conflict again! in gtkhtml and evolution.
> resolve all of them , reattached. 
> 
> Please reivew, thanks
> 
> 
> Hi,
> 
> Found conflict when I update code, so I resolve the conflict in the
> new gtkhtml patch attached.
> 
> And a error cause evolution hang when setting gtkhtml style is also
> fixed in the patch.  See snippet below,
> 
> --- src/gtkhtml.c       25 Jun 2003 18:15:46 -0000      1.518
> +++ src/gtkhtml.c       27 Jun 2003 05:00:43 -0000
> @@ -737,9 +737,9 @@
>         if (fixed_name) {
>                 fixed_desc = pango_font_description_from_string (fixed_name);
>                 if (pango_font_description_get_family (fixed_desc)) {
>                         fixed_size = PANGO_PIXELS (pango_font_description_get_size (fixed_desc));
> -                       (const gchar *) fixed_family = pango_font_description_get_family (fixed_desc);
> +                       (const gchar *) fixed_family = g_strdup(pango_font_description_get_family (fixed_desc));
>                 } else {
>                         g_free (fixed_name);
>                         fixed_name = NULL;
>                 }
> 
> The fixed_family is g_free() at end the gtk_html_set_fonts(), by
> looking at the defination, it should not be freed:
> 
> G_CONST_RETURN char *
> pango_font_description_get_family (const PangoFontDescription *desc)
> {
>   g_return_val_if_fail (desc != NULL, NULL);
>                                                                                 
>   return desc->family_name;
> }
> 
> 
> Thanks
> -York
> 
> 
> HI all,
> 
> Now put the option in the view/message display submenu. It is of
> 'toggle' type. see the snippet of evolution-mail-message.xml
> below(cannot take screenshot for menu, seems to be limitation of
> printscreen key):
> 
>   </submenu>
>     <submenu name="MessageDisplay" _label="_Message Display">
>     <menuitem name="ViewLoadImages" verb="" _label="Load _Images"/>
> +   <menuitem name="CaretMode" verb="" _label="Show _Blinking Cursor"/>
>      ... ...
> 
> And to find a name for the menu entry is really a headache. Anna, if you
> do not agree with the name "Show blinking cursor", could you give me a
> suggestion? 
> 
> A small change in patch of gtkhtml. Previously only setup the blinking
> cursor handler in focus in event handler. But if user already focus in a
> mail reader, and type f7 to turn on cursor, no focus in event. So we
> need to setup the blinking cursor there, and thus after cursor blinking
> event no focus in event.
> 
> Tested,
> 
> Regards
> York
> 
> 
> > Anyway, if we make this option available in the menus using the "F7"
> > key, then it will be more easy to quickly turn on and turn off than if
> > it is in the settings dialog. 
> > 
> > Further, it seems to me that many of the options which control how an
> > email is displayed are listed in the "View" menu. From that menu, one
> > can: 
> > 
> > * turn the preview pane on/off
> > * change the size of the text
> > * specify whether or not images are loaded
> > * specify whether email headers/source should be shown
> > 
> > It makes sense to me, therefore, to put the setting for caret mode in
> > the same menu, given that it is of similar scope (all these options
> > allow you to specify how you want to read your email messages.)
> > 
> > What do you think? 
> > 
> > Take care, 
> > Anna
> > 
> > 
> >