Re: [evolution-patches] Could you review my new patch for bug #44065

[Antonio Xu <antonio xu sun com>]

Hello fejj
Thanks for you reviewing my patch. Could you help me check my patch into 
trunk?
Anto
Jeffrey Stedfast wrote:

> ya, looks fine.
>
> On Fri, 2003-06-27 at 02:12, Antonio Xu wrote:
>  
>
> > Hello All
> > Who can review my patch for bug #44065? Thanks!
> >
> > Jeffrey Stedfast wrote:
> >
> > >sure, but can you get rid of the extra whitespace between:
> > >
> > >CamelURL * url;
> > >
> > >and
> > >
> > >url  = camel_url_new (content, NULL);
> > >
> > >thanks
> > >
> > >Jeff
> > >
> > >On Wed, 2003-06-25 at 23:04, Antonio Xu wrote:
> > >
> > >
> > >>
> > >>
> >
> >
> >
> > ______________________________________________________________________
> > Index: composer/ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
> > retrieving revision 1.542
> > diff -u -r1.542 ChangeLog
> > --- composer/ChangeLog	17 Jun 2003 19:47:53 -0000	1.542
> > +++ composer/ChangeLog	25 Jun 2003 14:08:08 -0000
> > @@ -1,3 +1,9 @@
> > +2003-06-25  Antonio Xu <antonio xu sun com>
> > +
> > +	Fixes bug #44065
> > +
> > +	* e-msg-composer.c(handle_mailto):Change file url to absolute path
> > +
> > 2003-06-16  Jeffrey Stedfast  <fejj ximian com>
> >
> > 	Fixes bug #44139.
> > Index: composer/e-msg-composer.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
> > retrieving revision 1.394
> > diff -u -r1.394 e-msg-composer.c
> > --- composer/e-msg-composer.c	17 Jun 2003 19:47:53 -0000	1.394
> > +++ composer/e-msg-composer.c	26 Jun 2003 02:54:16 -0000
> > @@ -3819,6 +3819,7 @@
> > 	size_t nread, nwritten;
> > 	char *content;
> > 	int len, clen;
> > +	CamelURL *url;
> > 	
> > 	/* Parse recipients (everything after ':' until '?' or eos). */
> > 	p = mailto + 7;
> > @@ -3882,7 +3883,13 @@
> > 					}
> > 				}
> > 			} else if (!strncasecmp (header, "attach", len)) {
> > -				e_msg_composer_attachment_bar_attach (E_MSG_COMPOSER_ATTACHMENT_BAR (composer->attachment_bar), content);
> > +				/*Change file url to absolute path*/
> > +				if (!g_ascii_strncasecmp(content, "file:", 5)) {
> > +					url = camel_url_new (content, NULL);
> > +					e_msg_composer_attachment_bar_attach (E_MSG_COMPOSER_ATTACHMENT_BAR (composer->attachment_bar), url->path);
> > +					camel_url_free (url);
> > +				} else
> > +					e_msg_composer_attachment_bar_attach (E_MSG_COMPOSER_ATTACHMENT_BAR (composer->attachment_bar), content);
> > 			} else {
> > 				/* add an arbitrary header? */
> > 				e_msg_composer_add_header (composer, header, content);
> >