Re: [evolution-patches] fix for bug #44065

[Not Zed <notzed ximian com>]

I know that this is 1.6 but i'll comment anyway.  Actually i dont see
why this is 1.6 material?

1. someone else is already workin on a patch, it might be prudent (and
at least polite) to get their patch right rather than hacking on another
one, even if its probably less work in the short term :) ...
2. camel_url has set methods for a reason, doing path = uri->path;
url->path = NULL; relies on internal knowledge of how a camelurl's
internals work, and breaks the abstraction barrier.  its a no-no.
2.5. you forgot g_ascii_stracasecmp() :)
3. it would probably be simpler just to do something like:

CamelURL *uri = NULL;
char *path = content;

if (g_ascii_strncasecmp(content, "file:", 5) == 0) {
  uri = camel_url_new(content, NULL);
  if (uri)
    path = uri->path;
}
...bar_attach(path)
if (uri)
  camel_url_free(uri);

PS we should probably rename camelurl to cameluri, but oh well.	

On Thu, 2003-06-26 at 06:09, Jeffrey Stedfast wrote: