[evolution-patches] Re: gtkhtml leaks are green



On Wed, 2003-06-25 at 01:00, Larry Ewing wrote:
> This fixes a whole bunch of tiny leaks in gtkhtml.  I have some
> additional changes for htmlimage but I need to extract them from som
> animation fixes I was working on

this change doesn't seem to be right:

@@ -353,7 +353,6 @@ html_font_manager_get_font (HTMLFontMana
                        } else {
                                /* some unavailable non-default font => use default one */
                                font = html_font_manager_get_font (manager, NULL, style);
-                               html_font_ref (font, manager->painter);
                        }
                        if (font)
                                html_font_set_font (manager, set, style, font);

IIRC, it's used in case there is no "whatever-weird-font" available, so
default font is put in fontset and has to be referenced as it's in more
than one set.

otherwise it looks good to me.

Radek





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]