[evolution-patches] fix for bug #42630 (UI)



The "lets display a multi-envelope icon" code can't possibly work right
now because we simply don't have icons available for it, however - it
looks quite nice if we just use the parent message status as the status
icon, but let the boldness depend on either:

1. parent is unread
2. 1 or more children are unread

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com
? 42630.patch
? 43862.patch
? 43972-mailer.patch
? 44457-mailer.patch
? crash.txt
? empty-subject.patch
? global-gconf.patch
? mail-local.patch
? message-tree.c
? message-tree.h
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.2749
diff -u -r1.2749 ChangeLog
--- ChangeLog	12 Jun 2003 04:47:32 -0000	1.2749
+++ ChangeLog	16 Jun 2003 20:06:24 -0000
@@ -1,3 +1,11 @@
+2003-06-16  Jeffrey Stedfast  <fejj ximian com>
+
+	* message-list.c (ml_tree_value_at): Don't display an unread icon
+	for a parent message status if it has unread children but has been
+	read itself. Instead, show that we have unread children by just
+	making the message test bold (which it was already doing, so
+	yay... this was easy). Fixes bug #42630.
+
 2003-06-11  Jeffrey Stedfast  <fejj ximian com>
 
 	* mail-format.c (format_mime_part): We only really want to use
Index: message-list.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/message-list.c,v
retrieving revision 1.341
diff -u -r1.341 message-list.c
--- message-list.c	11 Jun 2003 16:19:36 -0000	1.341
+++ message-list.c	16 Jun 2003 20:06:27 -0000
@@ -895,18 +895,7 @@
 	g_assert (msg_info != NULL);
 	
 	switch (col){
-	case COL_MESSAGE_STATUS: {
-		ETreePath child;
-		
-		/* if a tree is collapsed, then scan its insides for details */
-		child = e_tree_model_node_get_first_child(etm, path);
-		if (child && !e_tree_node_is_expanded(message_list->tree, path)) {
-			if (subtree_unread(message_list, child))
-				return GINT_TO_POINTER (4);
-			else
-				return GINT_TO_POINTER (3);
-		}
-		
+	case COL_MESSAGE_STATUS:
 		if (msg_info->flags & CAMEL_MESSAGE_ANSWERED)
 			return GINT_TO_POINTER (2);
 		else if (msg_info->flags & CAMEL_MESSAGE_SEEN)
@@ -914,7 +903,6 @@
 		else
 			return GINT_TO_POINTER (0);
 		break;
-	}
 	case COL_FLAGGED:
 		return GINT_TO_POINTER ((msg_info->flags & CAMEL_MESSAGE_FLAGGED) != 0);
 	case COL_SCORE: {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]