[evolution-patches] 42861: shortcut-bar scroll buttons too large

[Mike Kestner <mkestner ximian com>]

The up/down buttons were slightly larger than necessary, and the arrows
pushed off-center by the padding this patch removes.

Mike 

Index: gal/shortcut-bar/ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/gal/shortcut-bar/ChangeLog,v
retrieving revision 1.71
diff -u -p -r1.71 ChangeLog
--- gal/shortcut-bar/ChangeLog	16 May 2003 16:59:47 -0000	1.71
+++ gal/shortcut-bar/ChangeLog	16 Jun 2003 16:31:32 -0000
@@ -1,3 +1,9 @@
+2003-06-16  Mike Kestner  <mkestner ximian com>
+
+	* e-vscrolled-bar.c (e_vscrolled_bar_init): remove padding 
+	from arrows, it made the buttons large and offcenter [42861]
+	Also remove redundant null checks that are performed by _IS_.
+
 2003-05-16  Mike Kestner  <mkestner ximian com>
 
 	* e-group-bar.c (e_group_bar_forall): iterate over the group
Index: gal/shortcut-bar/e-vscrolled-bar.c
===================================================================
RCS file: /cvs/gnome/gal/gal/shortcut-bar/e-vscrolled-bar.c,v
retrieving revision 1.11
diff -u -p -r1.11 e-vscrolled-bar.c
--- gal/shortcut-bar/e-vscrolled-bar.c	1 Apr 2003 06:31:47 -0000	1.11
+++ gal/shortcut-bar/e-vscrolled-bar.c	16 Jun 2003 16:31:32 -0000
@@ -136,7 +136,6 @@ e_vscrolled_bar_init (EVScrolledBar *vsc
 				       "up_button");
 	gtk_widget_set_parent (vscrolled_bar->up_ebox, GTK_WIDGET (vscrolled_bar));
 	arrow = gtk_arrow_new (GTK_ARROW_UP, GTK_SHADOW_OUT);
-	gtk_misc_set_padding (GTK_MISC (arrow), 1, 1);
 	gtk_widget_show (arrow);
 	gtk_container_add (GTK_CONTAINER (vscrolled_bar->up_button), arrow);
 	gtk_widget_show (vscrolled_bar->up_button);
@@ -156,7 +155,6 @@ e_vscrolled_bar_init (EVScrolledBar *vsc
 	gtk_widget_set_parent (vscrolled_bar->down_ebox,
 			       GTK_WIDGET (vscrolled_bar));
 	arrow = gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-	gtk_misc_set_padding (GTK_MISC (arrow), 1, 1);
 	gtk_widget_show (arrow);
 	gtk_container_add (GTK_CONTAINER (vscrolled_bar->down_button), arrow);
 	gtk_widget_show (vscrolled_bar->down_button);
@@ -243,7 +241,6 @@ e_vscrolled_bar_map (GtkWidget *widget)
 	EVScrolledBar *vscrolled_bar;
 	GtkAdjustment *adjustment;
 
-	g_return_if_fail (widget != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (widget));
 
 	vscrolled_bar = E_VSCROLLED_BAR (widget);
@@ -270,7 +267,6 @@ e_vscrolled_bar_unmap (GtkWidget *widget
 {
 	EVScrolledBar *vscrolled_bar;
 
-	g_return_if_fail (widget != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (widget));
 
 	vscrolled_bar = E_VSCROLLED_BAR (widget);
@@ -294,7 +290,6 @@ e_vscrolled_bar_size_request (GtkWidget 
 	GtkBin *bin;
 	GtkRequisition child_requisition;
 
-	g_return_if_fail (widget != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (widget));
 	g_return_if_fail (requisition != NULL);
 
@@ -337,7 +332,6 @@ e_vscrolled_bar_size_allocate (GtkWidget
 	GtkAllocation button_allocation, child_allocation;
 	gint border_width;
 
-	g_return_if_fail (widget != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (widget));
 	g_return_if_fail (allocation != NULL);
 
@@ -438,7 +432,6 @@ e_vscrolled_bar_add (GtkContainer *conta
 	EVScrolledBar *vscrolled_bar;
 	GtkBin *bin;
 
-	g_return_if_fail (container != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (container));
   
 	vscrolled_bar = E_VSCROLLED_BAR (container);
@@ -468,7 +461,6 @@ static void
 e_vscrolled_bar_remove (GtkContainer *container,
 			GtkWidget    *child)
 {
-	g_return_if_fail (container != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (container));
 	g_return_if_fail (child != NULL);
 	g_return_if_fail (GTK_BIN (container)->child == child);
@@ -486,7 +478,6 @@ e_vscrolled_bar_forall (GtkContainer *co
 			GtkCallback   callback,
 			gpointer      callback_data)
 {
-	g_return_if_fail (container != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (container));
 	g_return_if_fail (callback != NULL);
 
@@ -527,7 +518,6 @@ void
 e_vscrolled_bar_set_adjustment (EVScrolledBar     *vscrolled_bar,
 				GtkAdjustment     *adjustment)
 {
-	g_return_if_fail (vscrolled_bar != NULL);
 	g_return_if_fail (E_IS_VSCROLLED_BAR (vscrolled_bar));
 
 	if (adjustment)