Re: [evolution-patches] initial addressbook patches

[Chris Toshok <toshok ximian com>]

looks good

On Fri, 2003-06-13 at 18:17, Larry Ewing wrote:
> On Fri, 2003-06-13 at 17:38, Chris Toshok wrote:
> > This seems broken (you're checking *tempstr2 after it's been freed.)
> > 
> > probably want to move the g_frees up right after the ifs, so:
> > 
> > if (!tempstr2 || !*tempstr2) {
> > 	g_free (tempstr2);
> > 	g_object_get (...);
> > }
> > 
> > and add a "g_free (tempstr2);" around the "g_free (tempstr);" at the end
> > of that block.
> 
> Eeep.  Fixed version attached.
> 
> --Larry