Re: [evolution-patches] Request for review for patch to bug 44485

[Harry Lu <harry lu sun com>]

JP,
    Would you please to have a look at this bug?
    Thanks a lot!
        Harry

Harry Lu wrote:

Actually I had checked the return value of icaltimezone_get_display_name() and print it and its length to the stdout. It is OK.  I also checked the value before gtk_entry_set_text() using g_utf8_validate(), it is TRUE.  But there is a warning in the terminal window after e_timezone_entry_set_entry():

** (evolution:26003): WARNING **: Invalid UTF8 string passed to pango_layout_set_text()

And the text entry shows garbage chars.
Maybe it is not related to gettext.  But my patch does fix it. Anyone can help?

Do you have a build on SuSe 8.1 or 8.2? And can you reproduce it?  It cannot be reproduced on RH8.0 or solaris.
Thanks!
       Harry

Rodrigo Moya wrote:

On Wed, 2003-06-11 at 12:02, Harry Lu wrote:
  

Hi! Calendar maintainers,
	Here is a patch for bug 44485. Please review it. This bug happens on
Suse SLEC RC1 + SUN GNOME 2.2. I think it is related to gettext. Sorry I
don't know the detail.
	Thanks!		
		Harry

    

I don't understand why this fixes it. It would be better, IMO, to check
the value returned by icaltimezone_get_display_name and set it to an
empty string if NULL. I suppose that's the cause of the problem, not the
value returned by _(display_name).

Or am I wrong?

cheers

_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches