Re: [evolution-patches] Patch to fix Desktop File



+desktop_in_file = evolution.desktop.in.in
+desktop_file = $(desktop_in_file:.desktop.in.in=.desktop)
+$(desktop_in_file:.desktop.in.in=.desktop.in): $(desktop_in_file)
+       sed -e "s|\ BASE_VERSION\@|$(BASE_VERSION)|" $< > $@
+
 @INTLTOOL_DESKTOP_RULE@

FWIW ... this should be done using an implicit rule.

i.e.

%.desktop.in: %s.desktop.in.in
	sed -e ... (exactly the same).

(everything else remains the same too)

Make will automagically build the .in file, and then remove it after its
build the .desktop file.

Otherwise:
 - you need to add the .in file to cleanfiles
 - it keeps the file around unecessarily, which can affect dependency
calculations
 - (its actually more portable than multiple targets, but not an issue
in this case/with our code).

On Tue, 2003-06-10 at 06:20, Rodney Dawes wrote:
> This patch makes the desktop file call the actual binary, and
> adds evolution-alarm-notify to the bugzilla binaries list. It
> requires the addition of a new file.
> 
> -- dobey
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]