Re: [evolution-patches] camel-uid-cache.c robustness patch

[Jeffrey Stedfast <fejj ximian com>]

oops, 2 catches I just made:

- forgot to g_free (dirname); if camel_mkdir_hier() passes.
- should open() with O_RDONLY instead of O_RDWR

On Wed, 2003-06-04 at 16:37, Jeffrey Stedfast wrote:
> Here's another go at it, removed the mkdir_hier() code and #include'd
> camel-store.h for that implementation (so we don't have to have 2 copies
> of it).
> 
> Also took care of all the issues (except the g_strsplit() issue) that
> were brought up in the previous patch.
> 
> You'll note that a failed write() won't necessarily mean we won't still
> overwrite the previous cache with the new cache. there's some (hopefully
> correct) logic to figure out if we should try to overwrite the old cache
> anyway in an attempt to save as much as we can.
> 
> There's a biggish comment in the code explaining the logic so I won't
> repeat it in my mail.
> 
> Jeff
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com