Re: [evolution-patches] Fixes for Lists in HTML Forms

[Radek Doulík <rodo ximian com>]

The patch looks good, I will only prefer to not remove deprecation
define from Makefile.am and remove/undef it only around vicious
gtklist.h include like this:

/*
  FIXME
  we need to call deprecated GtkList, which is ised in non deprecated GtkCombo
  remove following preprocessor hackery once gtk+ is fixed
 */

#ifdef GTK_DISABLE_DEPRECATED
#undef GTK_DISABLE_DEPRECATED
#include <gtk/gtklist.h>
#define GTK_DISABLE_DEPRECATED 1
#else
#include <gtk/gtklist.h>
#endif

Radek

On Sun, 2003-06-01 at 17:56, Rodney Dawes wrote:
> This patch fixes 2 bugs in HTML form list widgets. Firstly, the treeview
> lists are getting the data from the wrong column. This spews out a bunch
> of errors about how the column is invalid and you should end the list of
> columns with -1. The second bug is that the value set for drop-downs, is
> not being selected by default. Unfortunately, to do this, I had to
> remove the GTK_DISABLE_DEPRECATED define from Makefile.am as GtkCombo is
> still using GtkList. But this makes forms work much more properly.
> 
> -- dobey
-- 
Radek Doulík <rodo ximian com>
Ximian, Inc.