[evolution-patches] Re: soup leaks

[Dan Winship <danw ximian com>]

On Mon, 2003-07-28 at 17:15, Joe Shaw wrote:
> On Mon, 2003-07-28 at 16:20, Dan Winship wrote:
> > The plugs up the largest remaining soup leak, as well as two smaller
> > NTLM-related ones.
> 
> This looks good.

Committed and tagged as 1.99.25, but it's not going out with evo 1.4.4
since it hasn't gotten tested yet...

> > The change to soup_message_cleanup is something I tried while hunting
> > down the leak, but after looking further, I realized it was both useless
> > and bogus. (That code path will only be hit when the response body
> > hasn't been set.)
> 
> Yeah, this seems very sketchy.  That req->response.owner assignment was
> a hack Alex put in to fix a lot of crashes we used to see.

Yeah, I looked through bugzilla for bugs closed around that time. It
presumably worked because there was an erroneous duplicate free
somewhere else which was turned into a non-duplicate free by virtue of
leaking the data here :-!

-- Dan