Re: [evolution-patches] Re: [Evolution-hackers] Possibility to save all attachments

[<anna ximian com>]

Hi Harry, Ettore and others,

Thank you for your work on this patch! I have read many, many bug reports
from people who want to use this feature, and I am happy that we will be
able to offer it to them soon. Nice work.

For the most part, I think that this patch seems good from a UI
perspective. There are a few little things that bother me. They are:

1. On my machine, it is difficult to tell when a directory has been
selected. Look at the following screenshot:
http://primates.ximian.com/~anna/save-all.png . Have I succeeded in
selecting the "Documents" directory? I cannot tell. If I press the "OK"
button, what will happen? Will my attachments be saved in "Desktop", or in
"Documents" ?

I'd really like it if we could make the selected directory -- in this
case, "Documents", appear in the text entry beneath the "Selection" label.
Yes, I know it is a directroy, not a file, and that file names usually go
in the "Selection" entry. To be clear, in this case, that would mean that
"Documents" would be shown in the text entry.  What do you think? I think
if it is possible for the name of the selected directory to be shown
there, then, that would be helpful in eliminating user confusion about
precisely where her files will be saved.

2. Cosmetic Stuff: The plural form of the singular noun "attachment" is
"attachments"; you tended to use "attachment", which is incorrect. The
labels you used in your patch should be updated as follows: the name of
the context menu item should be "Save all attachments..." (note that "all"
is not capitalized).

The title of the file selector should be shortened a bit, to be more
consistent with the window title naming conventions used in the rest of
Evolution; "Select Directory for Attachments" would be more appropriate.
What do you think of that? Just to let you know what the HIG says on the
matter, see
http://developer.gnome.org/projects/gup/hig/1.0/windows.html#window-props-titles
. The gist of the guidelines is that window titles should distinguish the
window from other windows, but should not provide unnecessary information.

3. As for making other places in the UI for this option, I agree with you;
figuring out the places where we should make this available is another
bug. Specifically, it is this bug:
http://bugzilla.ximian.com/show_bug.cgi?id=47048 . Let's discuss the
possibilities for how to present these options there.

Thank you,
Anna