Re: [evolution-patches] patch for 43558

[Dan Winship <danw ximian com>]

On Mon, 2003-07-28 at 21:16, Suresh Chandrasekharan wrote:
> Hi ,
> Pl. evaluate and apply the evolution patch for "43558
> Appointment Editor always gives time validation error for apptmnts for
> non-UTF-8 non ASCII locales."

> -       else if (!e_date_edit_parse_time (dedit, time_text, &tmp_tm))
> +       else if (!e_date_edit_parse_time (dedit, e_utf8_to_locale_string(time_text), &tmp_tm))

e_date_edit_parse_time passes the time_text to e_time_parse_time(). In
general, all public APIs should be using UTF8-encoded strings. So I
think it would be better to leave e-dateedit.c as it is and do the
conversion inside e-time-utils.c.

That would also fix the several other places in widgets/misc and
calendar/gui that call the e_time_parse_* functions and presumably all
currently suffer from the same bug you're trying to fix here.

-- Dan