Re: [evolution-patches] seek review for bug #46844 (addressbook)

[Chris Toshok <toshok ximian com>]

On Thu, 2003-07-24 at 19:37, jack.jia wrote:
> hello Chris!
>  
> When the user delete a subfolder from UI, the evoluiton only remove
> the local directory and the addressbook.db..., it can not delete the
> backend related with this subfolder in the evoluiton-wombat.  you
> know, the evolution-wombat is alive for ever. The backend will stay in
> wombat forever, it caused mem leak. I know
> pas-book-factory.c:backend_last_client_gone_cb can stop/unref the
> EBookView(Listener) and unref the EBook(Listener). but the
> backend_last_client_gone_cb can not be called when the user delete a
> subfolder from UI.

That's the bug - the backend should be removed from the hashtable when
all EBooks goes away that reference it.  I presume you only hit this bug
once you've opened a view on the contact folder that you then delete?

> If  the user add the subfolder with the same name as the delete
> folder, it will not add  a new backend for this new subfolder(a uri).
> and the new subfolder will use the backend belong to the delete
> subfolder,  and it is a critical error. so,  I think it a critical
> bug.

That's just a symptom of the actual bug.

Chris

> If you want to delete the backend from UI ,  you must add a method in
> the addressbook.idl, so, I hope you can consider my patch carefully.
> 
> Chris:  If you have some better suggestion or fix, please tell me
> ASAP.
> 
> Thanks
> Jack
> Chris Toshok wrote:
> > On Thu, 2003-07-24 at 01:38, jack wrote:
> >   
> > > Hi toshok:
> > > 
> > > The bug #46844 is a bug of addressbook, Could you review this patch for it?
> > > http://bugzilla.ximian.com/show_bug.cgi?id=46844
> > > 
> > > summary  of this bug is "Deleting contact folder does not remove files"
> > >     
> > Hm, I don't like this fix..  This all should happen automatically when
> > the PASBook is destroyed in the wombat - look at
> > pas-book-factory.c:backend_last_client_gone_cb.  This should be driven
> > by the destruction of the view in the UI, which will stop/unref the
> > EBookView(Listener) and unref the EBook(Listener).
> > 
> > If it's not happening then that's definitely a bug, but the idl
> > additions seem unnecessary.
> > 
> > Chris
> >   
>