[evolution-patches] [Fwd: Re: seeking review for bug 44862:]

[Yuedong Du <yuedong du sun com>]

Not sure if you notice this mail, just resend.

-York
-------- Original Message --------

Subject:	Re: seeking review for bug 44862:
Date:	Tue, 22 Jul 2003 18:03:41 +0800
From:	Yuedong Du <yuedong du sun com>
CC:	Radek Doulík <rodo ximian com>, hackers <evolution-hackers ximian com>, sceri-evolution-acc sun com, Larry Ewing <lewing ximian com>, evolutoin-patches ximian com
References:	<1056017037 1332 46 camel matchpoint PRC Sun COM> <1056033706 1190 5 camel aquarius> <1057119759 4490 46 camel matchpoint PRC Sun COM>

Radek and all,

The patch is only commited into a11y branch.
Now can I commited into HEAD, is it OK?

York

yuedong du wrote:

On Thu, 2003-06-19 at 22:41, Radek Doul铆k wrote:
  

Hi York,

thank you very much for this patch. It looks OK to me. I only wonder
when o is NULL at that place:

@@ -88,6 +89,8 @@
 html_utils_get_accessible (HTMLObject *o, AtkObject *parent)
 {
        AtkObject *accessible;
+
+       if (!o) return NULL;
 
        accessible = html_object_get_data (o, ACCESSIBLE_ID);

Do you know when is it called with NULL object and why? I would rather
like to see g_return_val_if_fail (o != NULL, NULL); at that place. I
dunno when it happens though.

    

Sorry, I have forgot when and where it crash. But it is no harm to do
so. 

Commit this patch in a11y-branch.

  

Cheers
Radek